[m-rev.] for post-commit review: Fix writing .module_dep files.

[Peter Wang]

On Mon, 01 Mar 2021 14:59:20 +1100 "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> 
> 2021-03-01 12:34 GMT+11:00 "Peter Wang" <novalazy at gmail.com>:
> > compiler/make.module_dep_file.m:
> >    Write foreign included file names to the .module_dep stream
> >    instead of the implicit output stream. The bug was introduced in
> >    commit 5f50259d16c12286261d070f04d66f2ab19ced92.
> 
> Thanks for that.
> 
> Have you considered specifying --warn-implicit-stream-calls
> for make.* in Mercury.options?

Oh, I thought it was enabled for the entire compiler directory already.
It looks to be a fairly big change that I don't want to get into right
now.

> 
> > tests/mmc_make/Mmakefile:
> >    mmc --make does not set a non-zero exit status even if there were
> >    problems reading a .module_dep file.
> 
> Has anyone considered changing this?
> 

One possible reason (this is just conjecture) to ignore *certain* errors
reading .module_dep files is if they can be regenerated if missing,
or regenerated when the compiler is upgraded but an older incompatible
.module_dep file is found. The user should not need to be manually
deleting things in the Mercury directory to get the build to proceed,
normally.

Peter