[m-rev.] for post-commit review: Fix writing .module_dep files.

Zoltan Somogyi zoltan.somogyi at runbox.com
Mon Mar 1 14:59:20 AEDT 2021


2021-03-01 12:34 GMT+11:00 "Peter Wang" <novalazy at gmail.com>:
> compiler/make.module_dep_file.m:
>    Write foreign included file names to the .module_dep stream
>    instead of the implicit output stream. The bug was introduced in
>    commit 5f50259d16c12286261d070f04d66f2ab19ced92.

Thanks for that.

Have you considered specifying --warn-implicit-stream-calls
for make.* in Mercury.options?

> tests/mmc_make/Mmakefile:
>    mmc --make does not set a non-zero exit status even if there were
>    problems reading a .module_dep file.

Has anyone considered changing this?

One thing that makes me wary whenever I have to touch make.*m
is the lack of design documentation about things like this.

The diff is fine.

Zoltan.


More information about the reviews mailing list