[m-rev.] for post-commit review: change hunks

Zoltan Somogyi zoltan.somogyi at runbox.com
Sat Jun 29 04:55:06 AEST 2019



On Sat, 29 Jun 2019 01:39:21 +1000 (AEST), Julien Fischer <jfischer at opturion.com> wrote:

> > +find_change_hunks(ContextSize0, Diffs, CHunks) :-
> > +    % If our caller passes us an invalid ContextSize0, we replace it
> > +    % with the default context size 3.
> > +    % XXX Would programmers prefer us to throw an exception here?
> 
> I think so; whichever approach is chosen should be documented.

Done.

> > +    % If
> 
> That comment is perhaps a touch too concise.

You are right; I am not replying to Philip II of Macedon.
https://en.wikipedia.org/wiki/Laconic_phrase

> The diff is fine otherwise.

Thank you.

Zoltan.


More information about the reviews mailing list