[m-rev.] for review: support parallel bootcheck using --use-mmc-make

Julien Fischer jfischer at opturion.com
Tue Jul 9 12:09:41 AEST 2019


On Mon, 8 Jul 2019, Zoltan Somogyi wrote:

> On Tue, 9 Jul 2019 02:53:31 +1000 (AEST), Julien Fischer <jfischer at opturion.com> wrote:
>> @@ -925,7 +961,7 @@ then
>>           MERCURY_MKINIT="$root/util/mkinit"
>>           export MERCURY_MKINIT
>>
>> -        if (cd $stage2dir && $MMAKE $mmake_opts $jfactor runtime)
>> +        if (cd $stage2dir && $MMAKE $mmake_opts MMAKEFLAGS=$jfactor  runtime)
>>           then
>>               echo "building of stage 2 runtime successful"
>>           else
>
> Why the change here? Mmc --make is not involved in this directory.
>
>> @@ -1017,7 +1053,7 @@ then
>>           fi
>>
>>           if (cd $stage2dir/trace && \
>> -            $MMAKE $mmake_opts $jfactor trace $ENVGRADE)
>> +            $MMAKE $mmake_opts $mmake_jobs trace $ENVGRADE)
>>           then
>>               echo "building of stage 2 trace successful"
>>           else
>
> This looks wrong. And why the difference from the runtime directory,
> which should be treated the same?

No, both of the above are left over from an older version of this
change that I didn't undo properly.  Fixed.

> The rest looks fine.

Thanks.

Julien.


More information about the reviews mailing list