[m-rev.] for review: support parallel bootcheck using --use-mmc-make

Zoltan Somogyi zoltan.somogyi at runbox.com
Tue Jul 9 04:48:06 AEST 2019



On Tue, 9 Jul 2019 02:53:31 +1000 (AEST), Julien Fischer <jfischer at opturion.com> wrote:
> @@ -925,7 +961,7 @@ then
>           MERCURY_MKINIT="$root/util/mkinit"
>           export MERCURY_MKINIT
> 
> -        if (cd $stage2dir && $MMAKE $mmake_opts $jfactor runtime)
> +        if (cd $stage2dir && $MMAKE $mmake_opts MMAKEFLAGS=$jfactor  runtime)
>           then
>               echo "building of stage 2 runtime successful"
>           else

Why the change here? Mmc --make is not involved in this directory.

> @@ -1017,7 +1053,7 @@ then
>           fi
> 
>           if (cd $stage2dir/trace && \
> -            $MMAKE $mmake_opts $jfactor trace $ENVGRADE)
> +            $MMAKE $mmake_opts $mmake_jobs trace $ENVGRADE)
>           then
>               echo "building of stage 2 trace successful"
>           else

This looks wrong. And why the difference from the runtime directory,
which should be treated the same?

The rest looks fine.

Zoltan.


More information about the reviews mailing list