[m-rev.] for pre-review: one_or_more.m and one_or_more_map.m

Zoltan Somogyi zoltan.somogyi at runbox.com
Mon Dec 30 05:49:30 AEDT 2019


I have now written a first draft of the one_or_more.m and one_or_more_map.m
modules we sort-of discussed over the last day. I would like feedback on whether
they contain the right functionality, so I am sending this partial diff. Since the diff
removes the one_or_more type from list.m, a full diff would require changes to
all the compiler modules that used that type, and there are a lot of them. However,
that would also cause huge conflicts with the big change I am working on that
motivated the new modules in the first place. So I am proposing to commit
this diff not on its own, but as part of that later, big diff. (Right now, that full diff
touches 88 files and contains 25k+ lines.)

My two main questions are:

- Which, if any, of the currently-commented-out parts of one_or_more.m, which
  now contain just code copied from list.m, be adapted to one_or_mores and
  included in the module, and which should just be deleted as inapplicable
  or unneeded with one_or_mores.

- What predicates in one_or_more.m should have their outputs compared to the
  outputs of the corresponding list.m predicates on the same data. Some are
  too simple to need testing, while some definitely need it; help me draw the line
  between them.

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.one_or_more
Type: application/octet-stream
Size: 1676 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20191230/25cbe10a/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.one_or_more
Type: application/octet-stream
Size: 156044 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20191230/25cbe10a/attachment-0003.obj>


More information about the reviews mailing list