[m-rev.] for post-commit review: fix mantis bug 401

Peter Wang novalazy at gmail.com
Sat Aug 3 20:03:10 AEST 2019


On Sat, 03 Aug 2019 11:12:02 +0200 (CEST), "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
>  
> > > +        % Get the .int files of the modules imported using `use_module'
> > > +        % in the interface and `import_module' in the implementation.
> > > +        process_module_int123_files(Globals, HaveReadModuleMapInt,
> > > +            "int_used_imp_imported", pik_direct(int123_1, may_be_unqualified),
> > > +            make_ims_used_and_imported(import_locn_interface),
> > > +            make_ims_abstract_imported,
> > > +            module_and_imports_add_direct_int_item_blocks,
> > > +            IntUsedImpImported, !IntIndirectImported, set.init, _,
> > > +            !ModuleAndImports, !IO),
> > > +
> > 
> > Can you explain why we get the .int files for "int used, imp imported"
> > modules, whereas we get the .int3 files for other modules?
> 
> As I expect you already suspect, it was a cut-and-paste error.
> Thanks for catching it.

Hi Zoltan,

        % Get the .int files of the modules imported using `use_module'

.int3

        % in the interface and `import_module' in the implementation.
        process_module_int123_files(Globals, HaveReadModuleMapInt,
            "int_used_imp_imported", pik_direct(int123_3, may_be_unqualified),

"unqual_int_used_imp_imported"

            make_ims_used_and_imported(import_locn_interface),
            make_ims_abstract_imported,

make_ims_int3_implementation

            module_and_imports_add_direct_int_item_blocks,
            IntUsedImpImported, !IntIndirectImported, set.init, _,
            !ModuleAndImports, !IO),

Peter


More information about the reviews mailing list