[m-rev.] for post-commit review: fix mantis bug 401

Zoltan Somogyi zoltan.somogyi at runbox.com
Sat Aug 3 19:12:02 AEST 2019



On Sat, 3 Aug 2019 17:32:03 +1000, Peter Wang <novalazy at gmail.com> wrote:
> > diff --git a/compiler/grab_modules.m b/compiler/grab_modules.m
> > index 2dab1ce49..8ff23bd02 100644
> > --- a/compiler/grab_modules.m
> > +++ b/compiler/grab_modules.m
> > @@ -329,8 +329,7 @@ grab_imported_modules_augment(Globals, SourceFileName, SourceFileModuleName,
> >          % Get the .int files of the modules imported using `use_module'
> >          % in the interface and `import_module' in the implementation.
> >          process_module_int123_files(Globals, HaveReadModuleMapInt,
> > -            "int_used_imp_imported",
> > -            pik_direct(int123_1, may_be_unqualified),
> > +            "int_used_imp_imported", pik_direct(int123_1, may_be_unqualified),
> >              make_ims_used_and_imported(import_locn_interface),
> >              make_ims_abstract_imported,
> >              module_and_imports_add_direct_int_item_blocks,
> 
> BTW, the parameters in the documentation of process_module_int123_files
> don't match the code.

Fixed.
 
> > +        % Get the .int files of the modules imported using `use_module'
> > +        % in the interface and `import_module' in the implementation.
> > +        process_module_int123_files(Globals, HaveReadModuleMapInt,
> > +            "int_used_imp_imported", pik_direct(int123_1, may_be_unqualified),
> > +            make_ims_used_and_imported(import_locn_interface),
> > +            make_ims_abstract_imported,
> > +            module_and_imports_add_direct_int_item_blocks,
> > +            IntUsedImpImported, !IntIndirectImported, set.init, _,
> > +            !ModuleAndImports, !IO),
> > +
> 
> Can you explain why we get the .int files for "int used, imp imported"
> modules, whereas we get the .int3 files for other modules?

As I expect you already suspect, it was a cut-and-paste error.
Thanks for catching it.

Zoltan.


More information about the reviews mailing list