[m-rev.] for review: add builtin 64-bit integer types -- part 2

Julien Fischer jfischer at opturion.com
Sat Feb 3 22:08:06 AEDT 2018


On Sat, 3 Feb 2018, Zoltan Somogyi wrote:

> I just got four test failures that look related to this diff.
>
> As the attached bootcheck output shows, each of the
> four test cases that failed test uint64 operations.
> All test failures consist of a crash of the *compiler*,
> with the contents of the attached ABORT file
> being written directly to the terminal (not stdout or stderr;
> both went to Out.feb3).
>
> I remembered something from my review, and had a hunch.
> Changing the 20 to 21 in the C foreign proc for uint64_to_string
> in string.m fixes the problem. The problem was that UINT64_MAX
> has 20 decimal digits, one more than INT64_MAX.

Thanks for fixing that.

Julien.


More information about the reviews mailing list