[m-rev.] for review: add builtin 64-bit integer types -- part 2

Zoltan Somogyi zoltan.somogyi at runbox.com
Sat Feb 3 21:33:39 AEDT 2018




I just got four test failures that look related to this diff.

As the attached bootcheck output shows, each of the
four test cases that failed test uint64 operations.
All test failures consist of a crash of the *compiler*,
with the contents of the attached ABORT file
being written directly to the terminal (not stdout or stderr;
both went to Out.feb3).

I remembered something from my review, and had a hunch.
Changing the 20 to 21 in the C foreign proc for uint64_to_string
in string.m fixes the problem. The problem was that UINT64_MAX
has 20 decimal digits, one more than INT64_MAX.

I am committing this fix.

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Out.feb3.gz
Type: application/x-gzip
Size: 97803 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20180203/6a7535df/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ABORT
Type: application/octet-stream
Size: 18507 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20180203/6a7535df/attachment-0001.obj>


More information about the reviews mailing list