[m-rev.] for review: module_add_type_defn

[Zoltan Somogyi]

On Thu, 29 Jun 2017 01:28:42 +1000 (AEST), Julien Fischer <jfischer at opturion.com> wrote:
> > +abstract_solver_type.m:015: Error: this definition of type `foo1'/0 is not a
> > +abstract_solver_type.m:015:   solver type, but its previous declaration is.
> > +abstract_solver_type.m:009:   The previous declaration is here.
> > +abstract_solver_type.m:017: Error: this definition of type `foo2'/0 is not a
> > +abstract_solver_type.m:017:   solver type, but its previous declaration is.
> > +abstract_solver_type.m:010:   The previous declaration is here.
> > +abstract_solver_type.m:021: Error: this definition of type `foo3'/0 is not a
> > +abstract_solver_type.m:021:   solver type, but its previous declaration is.
> > +abstract_solver_type.m:011:   The previous declaration is here.
> 
> The only slight quibble I have here is with the use of the word
> "previous".  It is possible that the definition may precede the
> declaration in the source code order.  I will grant that it's very
> unlikely (and not particularly advisable) but in principle nothing in
> Mercury prevents that from being done.

You are right. The attached diff fixes the wording in those cases.

Zoltan.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.prev
Type: application/octet-stream
Size: 357 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20170629/5c3bda52/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.prev
Type: application/octet-stream
Size: 6138 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20170629/5c3bda52/attachment-0003.obj>