[m-rev.] for review: mmakefiles.m

Zoltan Somogyi zoltan.somogyi at runbox.com
Mon Jun 12 09:12:03 AEST 2017



On Sun, 11 Jun 2017 15:38:35 +1000 (AEST), Julien Fischer <jfischer at opturion.com> wrote:
> I've had a look through this change and I'm happy for you to commit it
> as-is and deal with review comments post-commit.

Thank you; committed.

> I will test the compiler in the C#
> and Java grades once you commit this (and again as various stages of the
> new mmkaefile representation are enabled).

I committed my diff with the Mmakefile fragments generated using the
new mechanism commented out, to test whether the simplifying changes
I made to the old, direct-write-out mechanism work. However, I have
also bootchecked my diff with the mmakefile fragments being generated
via the new mechanism being the active ones, and they work (for me,
at least). So you can try out the new mechanism, on the Java and C#
as well as on the C grades, at any time, just by setting the value returned
by the get_mmake_mode function to one of the last two values.

Zoltan.




More information about the reviews mailing list