[m-rev.] for review: mmakefiles.m

Julien Fischer jfischer at opturion.com
Sun Jun 11 15:38:35 AEST 2017


Hi Zoltan,

On Sat, 10 Jun 2017, Zoltan Somogyi wrote:

> For review by anyone. The best way to review the meat of the diff,
> the change to write_deps_file.m, is by looking at the old and new versions
> with diff --side-by-side.
>
> I have tested this in hlc.gc, asm_fast.gc and asm_fast.gc.decldebug grades.
> I cannot test it Java or C# grades, since I don't have those installed
> on my laptop, so I would request someone who does have them installed
> to try them out.

I've had a look through this change and I'm happy for you to commit it
as-is and deal with review comments post-commit.  (Given the state of
the existing write_deps_file.m, reviewing it in detail is going to take
me some time.)

With respect to the non-C grades, all of them are required to use
mmc --make *not* mmake.  The only part of mmake that needs to work with
the non-C gades is '--use-mmc-make', and that is only for building the
standard library and compiler (i.e. users are not expected to use mmake
with the non-C grades at all).  The library is built in all of the non-C
grades as part of the ROTD builds; I will test the compiler in the C#
and Java grades once you commit this (and again as various stages of the
new mmkaefile representation are enabled).

Also, it looks as though there is some residual support for the Java
grade and mmake in write_deps_file.m.  (When we were initially
developing the Java backend it did work with mmake for a time.)  I say
it's residual because there is no corresponding code for the C# and
Erlang backends there.

Julien.


More information about the reviews mailing list