[m-rev.] for review: Reorganise dependency graph code

Paul Bone paul at bone.id.au
Thu Feb 16 12:36:38 AEDT 2017


On Thu, Feb 16, 2017 at 12:52:25AM +1100, Zoltan Somogyi wrote:
> 
> 
> On Wed, 15 Feb 2017 22:15:03 +1100, Paul Bone <paul at bone.id.au> wrote:
> > Hi Zoltan, This is some of the work I had done to move generic parts of
> > hlds_dependency_graph.m into dependency_graph.m.  Even if we don't create
> > a dependency graph module form the MLDS I think this is still an improvement.
> 
> A minor improvement, but an improvement nevertheless.
> 
> You changed several predicates into functions: why? I think they were
> better off as predicates.

Mostly a preference, they have multiple inputs and a single output.  I
prefer this in particular for the functions that mostly retrive data from an
abstract type.

> Go ahead; I will fix the typos I found after you commit.

Okay.


-- 
Paul Bone
http://paul.bone.id.au


More information about the reviews mailing list