[m-rev.] for review: Reorganise dependency graph code

Zoltan Somogyi zoltan.somogyi at runbox.com
Thu Feb 16 00:52:25 AEDT 2017



On Wed, 15 Feb 2017 22:15:03 +1100, Paul Bone <paul at bone.id.au> wrote:
> Hi Zoltan, This is some of the work I had done to move generic parts of
> hlds_dependency_graph.m into dependency_graph.m.  Even if we don't create
> a dependency graph module form the MLDS I think this is still an improvement.

A minor improvement, but an improvement nevertheless.

You changed several predicates into functions: why? I think they were
better off as predicates.

Go ahead; I will fix the typos I found after you commit.

Zoltan.


More information about the reviews mailing list