[m-rev.] for review: --warn-no-stream-calls

Zoltan Somogyi zoltan.somogyi at runbox.com
Sat Oct 15 22:54:23 AEDT 2016


On Sat, 15 Oct 2016 21:37:24 +1100 (AEDT), Julien Fischer <jfischer at opturion.com> wrote:
> I suggest --warn-implicit-stream-calls as the option name.  It's really the
> implicitness of the stream calls that is the issue.  (Also, the negated form of
> the original name is --no-warn-no-stream-calls, which is a little unwieldy.)

I agree, and made the change.

The attached diff addresses both this review, and the previous one.
It is for post commit review by Julien.

Zoltan.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.warn_reviews
Type: application/octet-stream
Size: 1315 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20161015/d41b6765/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.warn_reviews
Type: application/octet-stream
Size: 31058 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20161015/d41b6765/attachment-0003.obj>


More information about the reviews mailing list