[m-rev.] for review: --warn-no-stream-calls

Julien Fischer jfischer at opturion.com
Sat Oct 15 21:37:24 AEDT 2016


On Fri, 7 Oct 2016, Zoltan Somogyi wrote:

> For review by anyone.
>
> Some questions:
>
> Is this the right functionality for the new option? Specifically,
> should the same option govern whether we print warnings for calls
> to io.write_string/3 and for calls to io.tell? I put them together
> because warnings for the latter without warnings for the former are
> error-prone. A piece of code may have N calls to io.write_string/3
> between one io.tell/told pair; if you eliminate the tell/told pair
> while adding an explicit stream argument to M < N of the calls to
> io.write_string/3, you still want to get warnings for the N - M calls
> you missed.

It's what I would expect it do do.

> Is this the right name for the new option? (This depends on the
> answer to the first question, of course.)

I suggest --warn-implicit-stream-calls as the option name.  It's really the
implicitness of the stream calls that is the issue.  (Also, the negated form of
the original name is --no-warn-no-stream-calls, which is a little unwieldy.)

> Is the existing documentation enough for the new option? (Again,
> this depends on the answers to the previous questions.)

Yes.

Julien.


More information about the reviews mailing list