[m-rev.] for review: Uncomment foreign code definition for clock/3.
Julien Fischer
jfischer at opturion.com
Wed May 25 11:14:30 AEST 2016
On Wed, 25 May 2016, Paul Bone wrote:
> On Tue, May 24, 2016 at 03:38:33PM +0800, Sebastian Godelet wrote:
>> Hello Paul,
>>
>> > diff --git a/library/time.m b/library/time.m index bf4caad..ea9c569 100644
>> > --- a/library/time.m
>> > +++ b/library/time.m
>> > @@ -264,16 +264,14 @@ time.clock(Result, !IO) :- "
>> > Ret = (MR_Integer) clock();
>> > ").
>> > -/* XXX need to add System.dll to the references list.
>> > :- pragma foreign_proc("C#",
>> > time.c_clock(Ret::out, _IO0::di, _IO::uo),
>> > [will_not_call_mercury, promise_pure, tabled_for_io], "{
>> > // XXX Ticks is long in .NET!
>> > - Ret = (int) System.Diagnostics.Process.GetCurrentProcess
>> > - .UserProcessorTime.Ticks;
>> > + Ret = (int) System.Diagnostics.Process.GetCurrentProcess().
>>
>
> I'm more concerned about the XXX referring to System.dll. Is a references
> list a .NET thing? Is adding System.dll a problem?
I've no idea what that comment is supposed to mean. It probably
doesn't matter since it predates the current C# backend, so presuambly
whatever it was referring to was actually an issue for the old IL
backend.
Julien.
More information about the reviews
mailing list