[m-rev.] for review: Uncomment foreign code definition for clock/3.

Paul Bone paul at bone.id.au
Wed May 25 10:58:21 AEST 2016


On Tue, May 24, 2016 at 03:38:33PM +0800, Sebastian Godelet wrote:
> Hello Paul,
> 
> > diff --git a/library/time.m b/library/time.m index bf4caad..ea9c569 100644
> > --- a/library/time.m
> > +++ b/library/time.m
> > @@ -264,16 +264,14 @@ time.clock(Result, !IO) :-  "
> >      Ret = (MR_Integer) clock();
> >  ").
> > -/* XXX need to add System.dll to the references list.
> >  :- pragma foreign_proc("C#",
> >      time.c_clock(Ret::out, _IO0::di, _IO::uo),
> >      [will_not_call_mercury, promise_pure, tabled_for_io],  "{
> >      // XXX Ticks is long in .NET!
> > -    Ret = (int) System.Diagnostics.Process.GetCurrentProcess
> > -        .UserProcessorTime.Ticks;
> > +    Ret = (int) System.Diagnostics.Process.GetCurrentProcess().
> 

I'm more concerned about the XXX referring to System.dll.  Is a references
list a .NET thing?  Is adding System.dll a problem?


-- 
Paul Bone


More information about the reviews mailing list