[m-rev.] for review: simplify profiler feedback code

[Julien Fischer]

On Sun, 30 Nov 2014, Zoltan Somogyi wrote:

> On Sat, 29 Nov 2014 19:31:24 +1100 (EST), "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
>> Ah. It seems that we were talking past each other. The comment on
>> read_or_create in mdbcomp/feedback.m said "ProgramName is the name
>> of the program that generated this feedback file". I took that to mean
>> that it is the name of mdprof_create_feedback, or a similar Mercury tool
>> that creates feedback files. Your comment makes it clear to me that it is
>> meant to be the name NOT of the program that generated the feedback
>> file, but of the program the feedback file was generated FOR, i.e. the
>> name of the program whose execution created the Deep.data file
>> the feedback was created FROM. That makes much more sense.
>> I will fix the misleading comment, and I will look over all the code
>> that handles these program names with that in mind.
>
> I have now done that, and modified all the code touching that field
> according to this better interpretation. I also addressed all the issues
> identified in the review of the original diff. The result is the updated
> diff attached to this mail. Since the diff for mdbcomp/feedback.m
> is quite confusing due to the big changes to that file, I have attached
> it separately as well.
>
> I have bootchecked this in a deep profiling grade, and the only failures
> were test cases that always fail in such grades. (I will fix these separately.)

Incidentally, this also fixes bug #181, which I have now marked as
fixed.

Cheers,
Julien.