[m-rev.] for review: simplify profiler feedback code
Zoltan Somogyi
zoltan.somogyi at runbox.com
Mon Dec 1 21:50:37 AEDT 2014
On Mon, 1 Dec 2014 11:25:17 +1100, Paul Bone <paul at bone.id.au> wrote:
> I've taken a quick look now (I didn't have any major concerns anyway). Can
> you check the spelling of Jerome's name, It looks like you've spelt it
> Jereon.
Thanks for catching that. I have fixed it by copying the name from
compiler/introduce_parallelism.m, which also agrees with the name on
the contributors page.
> I that the correct spelling is Jerömé, but I understand how you
> feel about non-ASCII characters.
I am pretty sure that the fourth char above is wrong.
Yes, I do feel that nonASCII characters are inconvenient enough
to avoid using them, even though my own name contains one such character :-)
> Also I think that pointing users at the date in a git repository can be a
> bit strange, as patches may not always be applied in date-order. Instead I
> suggest poƣnting users at the 14.01.1 release, in this case the feedback
> code in that release and in the master branch will be the same.
If I point people at the release they won't know what code is Tanniers
and what code isn't. The diff for today should make that clear.
> I think there's also more of Jerömé's code that can be removed. I can do
> this post-commit.
OK, thanks.
Zoltan.
More information about the reviews
mailing list