[m-rev.] Proposed changes to pqueue.m

Michael Richter ttmrichter at gmail.com
Tue Nov 19 03:11:13 AEDT 2013

On 18 November 2013 22:21, Julien Fischer <jfischer at opturion.com> wrote:

> Do we?  According to the Mercury project's coding standard we limit them
> to 79 characters.  And indeed, that's what most of the code does.

OK, which is it?  76 or 79?  I'm easy either way but I kind of want a solid
number.  ;)

> I suggest having three versions:
>  - peek, which returns both the key and the value
>  - peek_key, which returns the smallest key
>  - peek_value, which returns the value corresponding to the smallest key

I'll implement it that way tomorrow.

I'm at a bit of a loss for a use case of wanting to know the priority
without the value, though.  Have you got one?

> I prefer "unexpected($file, $pred, ..." since $pred already includes the
> module name.

Will change this tomorrow as well.

"Perhaps people don't believe this, but throughout all of the discussions
of entering China our focus has really been what's best for the Chinese
people. It's not been about our revenue or profit or whatnot."
--Sergey Brin, demonstrating the emptiness of the "don't be evil" mantra.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20131119/68195367/attachment.html>

More information about the reviews mailing list