[m-rev.] for post-commit review: from_ground_term_initial improvements

[Paul Bone]

On Tue, Apr 17, 2012 at 03:52:24PM +1000, Zoltan Somogyi wrote:
> On 17-Apr-2012, Paul Bone <pbone at csse.unimelb.edu.au> wrote:
> > > +    % - The order into which the goals should be put (Order).
> > > +    %
> > 
> > I don't see an argument named Order earlier in this comment.
> > It appears to be called Kind.
> 
> Fixed.
> 
> > > +    % Has a goal or sequence of goals broken the fgt{i,c} invariants?
> > > +    %
> > > +:- type maybe_kept
> > > +    --->    kept
> > > +    ;       broken.
> > > +
> > 
> > There was a type similar to this above.  If they have different semantics
> > please explain the semantics in the comment.
> 
> The difference in semantics is that the other type records additional
> information in the kept case. I would have thought that was clear
> from the names of the function symbols.
> 
> What info do you want that is not in the comment above the type definition?
> 

As I read on in the patch this became apparent, I forgot to go back and remove
my comment here.  No change is necessary.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20120417/3ec6750c/attachment.sig>