[m-rev.] for post-commit review: from_ground_term_initial improvements

Zoltan Somogyi zs at unimelb.edu.au
Tue Apr 17 15:52:24 AEST 2012


On 17-Apr-2012, Paul Bone <pbone at csse.unimelb.edu.au> wrote:
> > +    % - The order into which the goals should be put (Order).
> > +    %
> 
> I don't see an argument named Order earlier in this comment.
> It appears to be called Kind.

Fixed.

> > +    % Has a goal or sequence of goals broken the fgt{i,c} invariants?
> > +    %
> > +:- type maybe_kept
> > +    --->    kept
> > +    ;       broken.
> > +
> 
> There was a type similar to this above.  If they have different semantics
> please explain the semantics in the comment.

The difference in semantics is that the other type records additional
information in the kept case. I would have thought that was clear
from the names of the function symbols.

What info do you want that is not in the comment above the type definition?

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list