[m-rev.] for review: fix a comment
Ian MacLarty
maclarty at csse.unimelb.edu.au
Tue May 3 15:36:31 AEST 2011
On Mon, May 02, 2011 at 01:04:15PM +1000, Julien Fischer wrote:
>
> On Mon, 2 May 2011, Julien Fischer wrote:
>
> >
> >On Thu, 28 Apr 2011, Ian MacLarty wrote:
> >
> >>For review by anyone.
> >>
> >>Branches: main
> >>
> >>Change the comment describing the behaviour of
> >>parsing_utils.separated_list to
> >>match its actual behaviour.
> >>
> >>I didn't change the behaviour to match the comment, because the test case
> >>already tests that the predicate fails for empty sequences,
> >
> >That behaviour seems odd - I suspect the test case is wrong.
> >
> >>so that seems likely to have been the intended behaviour.
> >
> >There are two predicates named separated_list in this module. You have
> >only changed the documentation for one of them.
>
> Also, it is now inconsistent with that of comma_separated_list.
>
I don't see why, because comma_separated_list is described in terms of
separated_list.
Ian.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to: mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions: mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------
More information about the reviews
mailing list