[m-rev.] for post-commit review: Fix compatibility issues for the low-level C parallel grades.

Julien Fischer juliensf at csse.unimelb.edu.au
Tue Mar 23 17:40:31 AEDT 2010


On Tue, 23 Mar 2010, Paul Bone wrote:

> On Tue, Mar 23, 2010 at 04:31:12PM +1100, Julien Fischer wrote:
> >
> > The diff looks okay, although I wonder whether the use of the prefixes
> > _int and _uint might end up causing confusion between C's int type and
> > MR_Integer etc.
>
> I'll add a comment saying that they should be 'machine word sized integers'.
> That is they should be exactly as big as a general purpose register.
>
> > I would also be interested to now if this fixes the problems with
> > none.par.gc on eris.
>
> If there are current problems I don't know of them,  A quick search in the bug
> tracker only shows me this, which has been fixed:
>
> http://bugs.mercury.csse.unimelb.edu.au/view.php?id=121

That has been fixed, but in the nightly builds on eris a large number of
test cases are failing in none.par.gc.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list