[m-rev.] for post-commit review: Fix compatibility issues for the low-level C parallel grades.

Paul Bone pbone at csse.unimelb.edu.au
Tue Mar 23 17:33:31 AEDT 2010


On Tue, Mar 23, 2010 at 04:31:12PM +1100, Julien Fischer wrote:
> 
> The diff looks okay, although I wonder whether the use of the prefixes
> _int and _uint might end up causing confusion between C's int type and
> MR_Integer etc.

I'll add a comment saying that they should be 'machine word sized integers'.
That is they should be exactly as big as a general purpose register.

> I would also be interested to now if this fixes the problems with
> none.par.gc on eris.

If there are current problems I don't know of them,  A quick search in the bug
tracker only shows me this, which has been fixed:

http://bugs.mercury.csse.unimelb.edu.au/view.php?id=121

Thanks.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 489 bytes
Desc: Digital signature
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20100323/eac6c8e9/attachment.sig>


More information about the reviews mailing list