[m-rev.] New 'threadscope' grade

Paul Bone pbone at csse.unimelb.edu.au
Fri Dec 4 10:44:43 AEDT 2009


On Fri, Dec 04, 2009 at 10:34:32AM +1100, Julien Fischer wrote:
> On Fri, 4 Dec 2009, Zoltan Somogyi wrote:
>>> Maybe it should be called par_prof and one can have
>>> asm_fast.gc.par and asm_fast.gc.par_prof.
>>
>> I think we should use a more specific name than "prof" for this, but yes,
>> if we have a new grade component, that's roughly what it would look like.
>
> At the risk of starting heated discussions on this list - I can't do it
> in person as I would need to shout even louder than above - the name
> should not be composed of the names of two existing grade components, i.e.
> "par" and "prof".

How about 'threadscope' or maybe 'ts' since that's the main feature provided
here.  It should be combined with the par grade such that a full, suitable
grade would be:

    asm_fast.gc.par.threadscope

>>> and also learn how to create a new grade.
>>
>> Step 3: have a look at the comment at the top of runtime/mercury_grade.h,
>> look at how all the files listed there (and I do mean ALL) as well as
>> mercury_grade.h itself handle grades and grade components, and then do
>> what they do, adapted to the specific needs of the grade component
>> you are adding.
>
> I would also suggest having a look back through the CVS logs and have a
> look at what was changed last time a new grade component was added.

Good idea.

Thanks.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 489 bytes
Desc: Digital signature
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20091204/c5728e6c/attachment.sig>


More information about the reviews mailing list