[m-rev.] For review: Implement support for threadscope profiling.

[Julien Fischer]

On Fri, 4 Dec 2009, Zoltan Somogyi wrote:

>> I want to talk to Zoltan about making a new grade with this parallelism
>> profiling stuff in it.
>
> You will have to shout VERY LOUDLY :-(
>
> For now, and until this stuff has been fully debugged and we have reasonable
> confidence in its correctness (grounded in experience, not hope), I think
> we don't need a new grade for it, at least not committed in the repository.
>
>> Maybe it should be called par_prof and one can have
>> asm_fast.gc.par and asm_fast.gc.par_prof.
>
> I think we should use a more specific name than "prof" for this, but yes,
> if we have a new grade component, that's roughly what it would look like.

At the risk of starting heated discussions on this list - I can't do it
in person as I would need to shout even louder than above - the name
should not be composed of the names of two existing grade components, i.e.
"par" and "prof".

>> and also learn how to create a new grade.
>
> Step 1: have those heated discussions, and get people to agree that it is a
> good idea to create a new grade component.
>
> Step 2: have another heated discussion about what it should be called. For
> example, "prof" is a bad idea in this case, since it is already overloaded.
>
> Step 3: have a look at the comment at the top of runtime/mercury_grade.h,
> look at how all the files listed there (and I do mean ALL) as well as
> mercury_grade.h itself handle grades and grade components, and then do
> what they do, adapted to the specific needs of the grade component
> you are adding.

I would also suggest having a look back through the CVS logs and have a
look at what was changed last time a new grade component was added.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------