[m-rev.] for review: finish dir.m implementation for erlang backend

[Peter Wang]

On 2007-10-01, Ian MacLarty <maclarty at csse.unimelb.edu.au> wrote:
> > Index: library/dir.m
> > ===================================================================
> > RCS file: /home/mercury/mercury1/repository/mercury/library/dir.m,v
> > retrieving revision 1.43
> > diff -u -r1.43 dir.m
> > --- library/dir.m	21 Sep 2007 03:21:35 -0000	1.43
> > +++ library/dir.m	26 Sep 2007 01:07:17 -0000
> > @@ -1214,14 +1214,14 @@
> >      list(file_id)::in, bool::in, bool::in, bool::out, T::in,
> >      io.maybe_partial_res(T)::out, io::di, io::uo) is det.
> >  
> > -:- pred dir.foldl2_process_dir2(dir.stream::in, bool::in,
> > +:- pred dir.foldl2_process_dir2(dir.stream::in, dir.stream::out, bool::in,
> 
> Would it not be better to put the the dir.stream arguments at the end,
> where state arguments normally go?

Yes, maybe.

> Another approach might be to use an io_mutvar instead of a threaded
> pair.  Did you consider that option?

That's a bad idea for the Erlang backend (as explained in person).

Peter

--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------