[m-rev.] for review: finish dir.m implementation for erlang backend

Peter Ross pro at missioncriticalit.com
Mon Oct 1 14:56:31 AEST 2007


On 9/26/07, Peter Wang <novalazy at gmail.com> wrote:
> Estimated hours taken: 6
> Branches: main
>
> Finish implementation of dir.m for Erlang backend.
>
> library/dir.m:
>         Change the procedures in this module to thread `dir.stream' values
>         through them.  In the Erlang backend a `dir.stream' is a list of file
>         names in a directory, rather than a handle, so an output argument is
>         needed when reading an entry from the stream.
>
>         Implement the missing foreign_procs for Erlang.
>
> library/io.m:
>         Make the Erlang implementation of `io.file_type' support symlinks.
>
>         Implement `file_id' support for Erlang.
>
>         Fix the C implementation of compare on `file_id's, which did not take
>         into account file inodes at all.
>
>         Fix error handling in the Erlang implementation of
>         `io.make_symlink_2'.
>
> tests/hard_coded/dir_test.exp2:
>         Update expected output for the fixed `file_id' comparison.
>
> tests/hard_coded/dir_test.exp3:
>         Update expected output for a previous change (addition of
>         `dir.current_directory').

Looks fine.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list