[m-rev.] for review: build Mercury using MSVC 6

Peter Ross pro at missioncriticalit.com
Sun Feb 18 17:51:50 AEDT 2007


On 2/18/07, Julien Fischer <juliensf at csse.unimelb.edu.au> wrote:
> On Sat, 17 Feb 2007, Peter Ross wrote:
> > Index: library/par_builtin.m
> > ===================================================================
> > RCS file: /home/mercury1/repository/mercury/library/par_builtin.m,v
> > retrieving revision 1.9
> > diff -u -r1.9 par_builtin.m
> > --- library/par_builtin.m     6 Feb 2007 06:47:35 -0000       1.9
> > +++ library/par_builtin.m     17 Feb 2007 11:42:27 -0000
> > @@ -82,6 +82,7 @@
> >     };
> > #else /* !MR_THREAD_SAFE */
> >     struct MR_Future {
> > +        int x;
> >     };
> > #endif /* !MR_THREAD_SAFE */
>
> I suggest s/x/dummy/ and also add a comment along the lines of:
>
>         ANSI C does not support empty structs.
>
> The rest looks okay.
>
done and now committed.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list