[m-rev.] for review: fix asm_fast.par.gc
Zoltan Somogyi
zs at cs.mu.OZ.AU
Thu Mar 9 11:24:50 AEDT 2006
On 08-Mar-2006, Peter Wang <wangp at students.cs.mu.OZ.AU> wrote:
> +++ runtime/mercury_context.c 7 Mar 2006 23:18:54 -0000
> @@ -109,7 +109,8 @@
> 0, MR_detstack_size, MR_next_offset(),
> MR_detstack_zone_size, MR_default_handler);
> }
> - c->MR_ctxt_sp = c->MR_ctxt_detstack_zone->MR_zone_min;
> + /* sp points to the last used word, not to the first free word. */
> + c->MR_ctxt_sp = c->MR_ctxt_detstack_zone->MR_zone_min - 1;
>
> if (c->MR_ctxt_nondetstack_zone != NULL) {
> MR_reset_redzone(c->MR_ctxt_nondetstack_zone);
>
>
>
> It does, however, break tests/debugger/nondet_stack. A sample of the
> log follows. I think it's just a matter of adding another expected
> output case to reflect that the stack pointer is one less than it was
> before ?
That would be a bad idea. Peter, you should talk to me in person before
committing this.
Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
post: mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------
More information about the reviews
mailing list