[m-rev.] for review: fix asm_fast.par.gc

[Peter Wang]

On 2006-03-08, Julien Fischer <juliensf at cs.mu.OZ.AU> wrote:
> >
> > I've changed the fix a little.  Now MR_ctxt_sp is set to be one word
> > before MR_zone_min when the context is initialised (analogous to what
> > happens for MR_ctxt_maxfr a few lines later).  That makes the
> > MR_fork_new_context() code simpler, and maybe more correct.
> 
> maybe more correct?

The previous fix to MR_fork_new_context() was rather hackish.  Since
MR_sp points to a _used_ word, we should increment the stack pointer
before placing a value in that slot, rather than postincrementing.  It
worked anyway because we're creating a new context so there's nothing
yet on the newly allocated stack.

> > Tabling seems to be broken in the .par grade, but didn't show up until I
> > rebootchecked with a fresh copy of the testsuite.  Here are the failing
> > tests.  Setting up the nightly tests would be good, but fib_list enters
> > into an infinite loop so it may need to be disabled for the time being.
> 
> I suspect tabling has never really been tested with the .par grades
> (I _know_ it hasn't been tested with it recently).  I'll get saturn
> and a few of the other machines to install asm_fast.gc.par and disable
> the tabling tests in that grade for the time being.

Great!

> > tabling/expand_poly
> > tabling/expand_tuple
> > tabling/fib_list
> > tabling/specified
> 
> Did you set MERCURY_SUPPRESS_STACK_TRACE to yes?

No.

Peter
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------