[m-rev.] diff: fix stack overflow with mmc --make

Zoltan Somogyi zs at cs.mu.OZ.AU
Mon Feb 20 18:36:44 AEDT 2006


On 20-Feb-2006, Julien Fischer <juliensf at cs.mu.OZ.AU> wrote:
> -        GoalCannotLoopOrThrow = no
> +        GoalCannotLoopOrThrow = yes

I suggest you reformulate your code to use a variable named GoalCanLoopOrThrow,
since it is always easier to work with variables whose semantics doesn't
require you to think in terms of double negatives. Further, the two values
of this variable shouldn't be yes and no, but can_loop_or_throw and
cannot_loop_or_throw.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list