[m-rev.] diff: fix stack overflow with mmc --make

Julien Fischer juliensf at cs.mu.OZ.AU
Mon Feb 20 17:15:50 AEDT 2006


Estimated hours taken: 3
Branches: main

Fix a bug in my recent change to use the intermodule-analysis framework that
broke `mmc --make' on compilers built at -O3 or greater.

compiler/constraint.m:
	Fix a typo.  We should *not* be performing constraint propagation
	on goals that may loop or throw an exception.

Julien.

Index: constraint.m
===================================================================
RCS file: /home/mercury1/repository/mercury/compiler/constraint.m,v
retrieving revision 1.68
diff -u -r1.68 constraint.m
--- constraint.m	16 Feb 2006 05:48:29 -0000	1.68
+++ constraint.m	20 Feb 2006 06:09:06 -0000
@@ -435,7 +435,7 @@
         goal_info_is_pure(GoalInfo),

         % Don't propagate goals that can loop or throw exceptions.
-        GoalCannotLoopOrThrow = no
+        GoalCannotLoopOrThrow = yes
     ->
         % It's a constraint, add it to the list of constraints
         % to be attached to goals earlier in the conjunction.

--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list