[m-rev.] for review: unchecked_logical_right_shift

[Julien Fischer]

On Fri, 29 Dec 2006, Simon Taylor wrote:

>
> Estimated hours taken: 2
> Branches: main

Briefly mention the motivation for this change.

>
> compiler/builtin_ops.m:
> compiler/bytecode.m:
> compiler/c_util.m:
> compiler/const_prop.m:
> compiler/llds.m:
> compiler/llds_out.m:
> compiler/gcc.m:
> compiler/mlds_to_gcc.m:
> compiler/mlds_to_il.m:
> compiler/mlds_to_c.m:
> compiler/java_util.m:
> 	Add a new builtin: unchecked_logical_right_shift.
> 	This needs to be bootstrapped before the declaration is added
> 	to library/int.m.
>
> 	XXX This doesn't work with `--target asm' because mlds_to_gcc.m
> 	currently has no way to cast to MR_Unsigned.  As far as I can
> 	tell `--target asm' is not tested anywhere.
> 	Is it supported any more?

It's not really supported anymore.  (Ian did test it a while back and
it was working then - I'm not sure what the current situation.)

I suggest putting an XXX comment at the head of mlds_to_gcc.m mentioning
this.

The rest of this diff looks fine.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------