[m-rev.] for review: don't do constant propagation if no-allow-inlining

Ian MacLarty maclarty at cs.mu.OZ.AU
Sun Mar 27 23:59:12 AEST 2005


On Mon, Mar 14, 2005 at 09:16:24AM +1100, Julien Fischer wrote:
> 
> Perhaps you should just add constant propagation to the list of things to
> turn of when execution tracing is enabled (in
> handle_options.post_process_options_2).
> 

Then I should also remove the line:
 	option_neg_implies(inline_builtins, constant_propagation, bool(no)),
since if no-inline-builtins implies no constant_propagation, then so should
no-allow-inlining.

The fix we discussed with Zoltan isn't making sense to me anymore.  If I
remember correctly the idea was to just turn off constant_propagation in the
simplify module when no-allow-inlining was specified.  This, however, is
exactly what is being done by my proposed diff.

Ian.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list