[m-rev.] for review: don't do constant propagation if no-allow-inlining

[Ian MacLarty]

On Mon, Mar 14, 2005 at 09:16:24AM +1100, Julien Fischer wrote:
> 
> On Sun, 13 Mar 2005, Ian MacLarty wrote:
> 
> > > > compiler/handle_options.m
> > > > 	If allow_inlining is no then turn of constant_propagation since this
> > > > 	inlines builtins.
> > > >
> > >
> > > I think that the correct fix here would not to enable constant propagation
> > > in the .debug and .decldebug grades (unless of course --trace-optimized
> > > was specified).
> > >
> >
> > What if the user specifies --no-inlining?  Should constant propagation
> > be done then?  Currently constant propogation is turned off if this option is
> > given.
> >
> > When tracing is enabled the allow-inlining option is set to no
> > but inline-builtins isn't (nor are any of the other inlinings).  I believe
> > this is done because inlining is turned off in other places for different
> > reasons and it's simpler to set one option than several.
> >
> 
> Perhaps you should just add constant propagation to the list of things to
> turn of when execution tracing is enabled (in
> handle_options.post_process_options_2).
> 

If I just do that then constant propagation won't be turned off when the user
gives the --no-allow-inlining option.  However it is turned off when the
--no-inline-builtins option is given.  So that wouldn't be very consistent.

> Julien.
> --------------------------------------------------------------------------
> mercury-reviews mailing list
> post:  mercury-reviews at cs.mu.oz.au
> administrative address: owner-mercury-reviews at cs.mu.oz.au
> unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
> subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
> --------------------------------------------------------------------------
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------