[m-rev.] for review: gathering trace counts

[Zoltan Somogyi]

On 23-Mar-2005, Julien Fischer <juliensf at cs.mu.OZ.AU> wrote:
> > 	Add sanity checking code that looks for and reports occurrences
> > 	of a situation reported by Peter Wang: positive counts for internal
> > 	events in a procedure with a missing (and hence zero) count for the
> > 	CALL event of that same procedure. Make this sanity check conditional
> > 	on the new configuration macro MR_TRACE_COUNT_DEBUG. The sanity check
> > 	did not find any anomalies during any of my bootchecks.
> >
> Did we ever find out why that was happening for Peter?

The sanity check was my attempt to do so. Since I couldn't get the error
to manifest itself, I am left to the conclusion that Peter must have used
the facility incorrectly.

> >  # Copyright (C) 1995-2001 The University of Melbourne.
> >  # This file may only be copied under the terms of the GNU General
> > @@ -14,11 +15,20 @@
> >  		directories will be run. In the absence of any such options,
> >  		all tests in all directories will be run (unless testing
> >  		as a whole is disabled).
> > +    -s <testname>, --specified-test <testname>
> > +	    Run only the tests whose names are specified as arguments of this
> > +		option, which may be given more than once. The test names must include
> > +		the directory name component.
> Indentation above?

As I mentioned earlier, I generate diffs with -b, so there is no point
in complaining about indentation in a diff which switches from 8-space
to 4-space indentation; any such apparent indentation errors are artifacts
of diff -b and not actual errors.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------