[m-rev.] for review: gathering trace counts

Julien Fischer juliensf at cs.mu.OZ.AU
Wed Mar 23 18:11:03 AEDT 2005



On Wed, 23 Mar 2005, Zoltan Somogyi wrote:

> For review by Ian or Julien.
>
> Zoltan.
>
> Provide a mechanism for gathering sets of trace counts from both passed and
> failed test cases.
>
> runtime/mercury_trace_base.[ch]:
> 	Instead of writing out trace counts to a file with a fixed name,
> 	write it out to a file whose name includes the name of the executable
> 	and the process id.
>
> 	Export only the functions that need to be exported.
>
> 	Add sanity checking code that looks for and reports occurrences
> 	of a situation reported by Peter Wang: positive counts for internal
> 	events in a procedure with a missing (and hence zero) count for the
> 	CALL event of that same procedure. Make this sanity check conditional
> 	on the new configuration macro MR_TRACE_COUNT_DEBUG. The sanity check
> 	did not find any anomalies during any of my bootchecks.
>
Did we ever find out why that was happening for Peter?

...

> Index: tools/bootcheck
> ===================================================================
> RCS file: /home/mercury/mercury1/repository/mercury/tools/bootcheck,v
> retrieving revision 1.166
> diff -u -b -r1.166 bootcheck
> --- tools/bootcheck	15 Feb 2005 05:22:38 -0000	1.166
> +++ tools/bootcheck	7 Mar 2005 11:34:30 -0000
> @@ -1,4 +1,5 @@
>  #!/bin/sh
> +# vim: ts=4 sw=4 wm=0 tw=0
>  #---------------------------------------------------------------------------#
>  # Copyright (C) 1995-2001 The University of Melbourne.
>  # This file may only be copied under the terms of the GNU General
> @@ -14,11 +15,20 @@
>  		directories will be run. In the absence of any such options,
>  		all tests in all directories will be run (unless testing
>  		as a whole is disabled).
> +    -s <testname>, --specified-test <testname>
> +	    Run only the tests whose names are specified as arguments of this
> +		option, which may be given more than once. The test names must include
> +		the directory name component.
Indentation above?

That looks fine otherwise.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list