[m-rev.] for review: don't do constant propagation if no-allow-inlining

[Julien Fischer]

On Sat, 12 Mar 2005, Ian MacLarty wrote:

> Another one found with the mdb dice command :-)
>
What's the emoticon for smug grin?


> Estimated hours taken: 2
> Branches: main
>
> Fix failing test debugger/declarative/binary_search.  The test fails with -O3
> and grade = *.debug.  It was failing because int.- was being inlined
> in certain places, because constant propagation was ignoring the allow_inlining
> option.

It's not really being inlined, it's being evaluated at those points, i.e
it won't be there (inlined or not) after constant propagation.

> compiler/handle_options.m
> 	If allow_inlining is no then turn of constant_propagation since this
> 	inlines builtins.
>

I think that the correct fix here would not to enable constant propagation
in the .debug and .decldebug grades (unless of course --trace-optimized
was specified).

Julien.



--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------