[m-rev.] for review: don't do constant propagation if no-allow-inlining

Ian MacLarty maclarty at cs.mu.OZ.AU
Sat Mar 12 19:55:36 AEDT 2005


Another one found with the mdb dice command :-)

Estimated hours taken: 2
Branches: main

Fix failing test debugger/declarative/binary_search.  The test fails with -O3
and grade = *.debug.  It was failing because int.- was being inlined
in certain places, because constant propagation was ignoring the allow_inlining
option.

compiler/handle_options.m
	If allow_inlining is no then turn of constant_propagation since this
	inlines builtins.

Index: compiler/handle_options.m
===================================================================
RCS file: /home/mercury1/repository/mercury/compiler/handle_options.m,v
retrieving revision 1.222
diff -u -r1.222 handle_options.m
--- compiler/handle_options.m	6 Mar 2005 05:17:27 -0000	1.222
+++ compiler/handle_options.m	12 Mar 2005 08:11:41 -0000
@@ -991,6 +991,7 @@
 
 	% `--constant-propagation' effectively inlines builtins.
 	option_neg_implies(inline_builtins, constant_propagation, bool(no)),
+	option_neg_implies(allow_inlining, constant_propagation, bool(no)),
 
 	% --no-reorder-conj implies --no-deforestation,
 	% --no-constraint-propagation and --no-local-constraint-propagation.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list