[m-rev.] for review: make get_functor handle existential types
Ian MacLarty
maclarty at cs.mu.OZ.AU
Mon Dec 13 17:32:20 AEDT 2004
On 13 Dec 2004, at 17:09, Zoltan Somogyi wrote:
> On 13-Dec-2004, Ian MacLarty <maclarty at cs.mu.OZ.AU> wrote:
>>> + Arity, PseudoTypeInfoList),
>>> + % If a pseudo_type_info in PseudoTypeInfoList is not ground,
>>> + % then the resulting TypeInfoList will be silently invalid and
>>> + % will cause a core dump sooner or later. This is
>>
>> Should there be something after "This is" other than the next line of
>> code?
>
> That should read "This is not good, but is no worse than the current
> behavior."
>
Doesn't ground_pseudo_type_desc_to_type_desc_det/1 throw a Mercury
exception if the pseudo_type_info is not ground? Since
ground_pseudo_type_desc_to_type_desc_det is applied to all the values
in PseudoTypeInfoList to generate TypeInfoList, isn't a core dump no
longer possible (at least due to a non-ground pseudo_type_info)?
Instead an exception will be thrown - which is at least nicer than a
seg fault.
Ian.
--------------------------------------------------------------------------
mercury-reviews mailing list
post: mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------
More information about the reviews
mailing list