[m-rev.] for review: make get_functor handle existential types

[Zoltan Somogyi]

On 13-Dec-2004, Ian MacLarty <maclarty at cs.mu.OZ.AU> wrote:
> > +		Arity, PseudoTypeInfoList),
> > +	% If a pseudo_type_info in PseudoTypeInfoList is not ground,
> > +	% then the resulting TypeInfoList will be silently invalid and
> > +	% will cause a core dump sooner or later. This is 
> 
> Should there be something after "This is" other than the next line of 
> code?

That should read "This is not good, but is no worse than the current behavior."

> > +                if (noncanon == MR_NONCANON_ALLOW) {
> > +                    /* XXX should be MR_collapse_equivalences_pseudo */
> 
> Why isn't it MR_collapse_equivalences_pseudo?

It is now. I did part of the work in another workspace which did not have
MR_collapse_equivalences_pseudo.

> The mix of `.' and `:' module qualifiers in the above comment looks a bit strange.

I thought I got them all, but didn't; I have now.

> > +    /*
> > +    ** Handle the comparison if either pseudo_type_info is a variable.
> > +    ** Any non-variable is greater than a nonvariable
> > +    */
> 
> Should that be "Any non-variable is greater than a variable."?

Yes.

I have followed your other cosmetic suggesstions.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------