[m-rev.] Re: your mail

[Fergus Henderson]

On 13-Oct-2003, Julien Fischer <juliensf at students.cs.mu.OZ.AU> wrote:
> 
> Add a little more functionality to the OpenGL binding.  In particular,
> add bindings for vertex fragment operations and (some) support for
> selection.  Make some trivial changes to the binding for mogl.get_error/3.

The rationale for adding functionality is obvious,
but what's the rationale for those trivial changes?
...
> Index: mogl.m
> @@ -443,13 +442,12 @@
>  		;	equal
>  		;	gequal
>  		;	greater
> -		;	notequal
> -		.
> +		;	not_equal.

That change isn't mentioned in the log message, is it?
It would be helpful to mention it and to give some rationale.

> @@ -487,19 +483,18 @@
...
> -:- type logical_operation
> +:- type logical_op

Likewise.

>  		--->	clear
>  		;	(and)
>  		;	and_reverse
>  		;	copy
>  		;	and_inverted
> -		;	noop
> +		;	no_op

Likewise.

> @@ -736,10 +727,9 @@
>  		GL_STACK_UNDERFLOW,
>  		GL_OUT_OF_MEMORY
>  	};
> -	GLenum	err;
> -	Integer i;
> -
> -	Err = 0;
> +
> +	GLenum	err = 0;
> +	int i;
> 
>  	err = glGetError();

There's no point setting err = 0 when you assign err = glGetError()
immediately afterwards.

Otherwise that looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------