[m-rev.] diff: trivial MC++ to C#
Peter Ross
pro at missioncriticalit.com
Wed Nov 12 21:36:48 AEDT 2003
On Tue, Nov 11, 2003 at 04:38:45PM +1100, Fergus Henderson wrote:
> On 07-Nov-2003, Peter Ross <pro at missioncriticalit.com> wrote:
> > Begin porting the the library just to use C# as its foreign_proc
> > language.
> ...
> > Index: library/int.m
> ...
> > -:- pragma foreign_proc("MC++",
> > +:- pragma foreign_proc("C#",
> > int__bits_per_int(Bits::out),
> > [will_not_call_mercury, promise_pure, thread_safe],
> > "
> > - Bits = ML_BITS_PER_INT;
> > + // XXX we are using int32 in the compiler.
> > + Bits = 32;
>
> It would be nicer to word that as
>
> // we are using int32 in the compiler.
> // XXX would be better to avoid hard-coding this here
>
> to make it clear what problem the XXX is referring to.
>
> Otherwise that looks fine.
>
Done.
--------------------------------------------------------------------------
mercury-reviews mailing list
post: mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------
More information about the reviews
mailing list