[m-rev.] diff: trivial MC++ to C#

Fergus Henderson fjh at cs.mu.OZ.AU
Tue Nov 11 16:38:45 AEDT 2003


On 07-Nov-2003, Peter Ross <pro at missioncriticalit.com> wrote:
> Begin porting the the library just to use C# as its foreign_proc
> language.
...
> Index: library/int.m
...
> -:- pragma foreign_proc("MC++",
> +:- pragma foreign_proc("C#",
>  	int__bits_per_int(Bits::out),
>  	[will_not_call_mercury, promise_pure, thread_safe],
>  "
> -	Bits = ML_BITS_PER_INT;
> +	// XXX we are using int32 in the compiler.
> +	Bits = 32;

It would be nicer to word that as

	// we are using int32 in the compiler.
	// XXX would be better to avoid hard-coding this here

to make it clear what problem the XXX is referring to.

Otherwise that looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list