[m-rev.] for review: library and browser namespaces

[Zoltan Somogyi]

On 23-Sep-2002, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> A brief comment here, e.g.
> 
> 	# Specify which files to check for namespace cleanliness,
> 	# and which name prefixes are allowed.
> 
> would be helpful, IMHO.

Done.

> > -	update_io(IO0, IO);
> > +	MR_update_io(IO0, IO);
> 
> You also need to modify library/time.m, which also refers to `update_io'.
> (Did `mmake check_namespace' catch that one?)

No, it didn't. The reason is that the existing rules for checking macros
match a #define only at the start of a line, and the #define of update_io
in time.m is not at the start of a line. I have fixed the awk pattern
to allow spaces before the #define.

My overnight bootcheck in hlc.gc did find some other violations, though.
bool.o defines the symbol

	base_typeclass_info_enum__enum__arity1__bool__bool__arity0__

and mdb.o defines mdb__version_1_p_0.

I will add mdb to the list of permitted prefixes in the browser, but you
should think about adding a prefix to the names of base_typeclass_infos
in hlc grades. Since we already have _entry as a prefix, using
_base_typeclass_info would be the minimum change.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------