[m-rev.] for review: library and browser namespaces

[Fergus Henderson]

On 23-Sep-2002, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> 
> Enforce namespace cleanliness in the library and browser directories
> as well as in the runtime and trace directories.

That looks good.

A few minor comments:

> Mmake.common.in:
> 	Move the rules check_namespace here (they used to be in the Mmakefiles
> 	of the runtime and trace directories), together with the variables they
> 	need. Generalize them to also handle the needs of the browser, library
> 	and bytecode directories. The former two in particular need the
> 	ability to check automatically generated .mh files.
> 
> 	Makefile all the rules used by check_namespace conditional on a macro

s/Makefile/Make/

> Index: browser/Mmakefile
> @@ -15,6 +15,12 @@
>  
> +CHECK_HDRS  =
> +CHECK_MHDRS = $(mer_browser.mhs)
> +CHECK_OBJS  = $(mer_browser.os)
> +ALLOW_LIB_PREFIX=yes
> +ALLOW_BROWSER_PREFIX=yes

A brief comment here, e.g.

	# Specify which files to check for namespace cleanliness,
	# and which name prefixes are allowed.

would be helpful, IMHO.

> Index: bytecode/Mmakefile
> Index: library/Mmakefile
> Index: runtime/Mmakefile
> Index: trace/Mmakefile

Likewise in these files.

> Index: library/io.m
> -	update_io(IO0, IO);
> +	MR_update_io(IO0, IO);

You also need to modify library/time.m, which also refers to `update_io'.
(Did `mmake check_namespace' catch that one?)

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------